Skip to content

Conversation

@humanagent
Copy link
Collaborator

@humanagent humanagent commented Nov 5, 2025

Update agent integrations to default to @xmtp/agent-sdk 1.1.10 and restrict Agent.createFromEnv in agents/bots/key-check/index.ts to ActionsCodec and IntentCodec

Bump the default agent SDK to 1.1.10 with updated version mappings and adjust the key-check bot to register only ActionsCodec and IntentCodec, while adding sender address logging in the agent.on('text') handler.

📍Where to Start

Start with the version map changes in agents/versions/agent-sdk.ts, then review the Agent.createFromEnv configuration and agent.on('text') handler in agents/bots/key-check/index.ts.


📊 Macroscope summarized 3bb4928. 2 files reviewed, 4 issues evaluated, 3 issues filtered, 0 comments posted

🗂️ Filtered Issues

agents/bots/key-check/index.ts — 0 comments posted, 2 evaluated, 2 filtered
  • line 299: Contract parity/regression: The codecs array was reduced to [new ActionsCodec(), new IntentCodec()], removing previously supported codecs MarkdownCodec, ReactionCodec, ReplyCodec, RemoteAttachmentCodec, AttachmentCodec, and WalletSendCallsCodec. If the agent receives or needs to emit messages using any of these content types (which were previously supported), it will be unable to decode/encode them. Depending on Agent.createFromEnv and the agent's message handling pipeline, this can result in runtime failures such as unrecognized content type errors, dropped messages, or failure to process basic text/markdown messages. This is a visible behavior change and breaks parity with the earlier externally visible contract for supported content types. [ Low confidence ]
  • line 299: Potential initialization/runtime failure: If Agent.createFromEnv expects a baseline text/markdown codec to be present (for system messages, fallbacks, or default decoding), reducing codecs to only ActionsCodec and IntentCodec can cause agent startup to fail or lead to exceptions when processing basic messages. This is a plausible runtime bug given the previously included MarkdownCodec. [ Low confidence ]
agents/versions/agent-sdk.ts — 0 comments posted, 2 evaluated, 1 filtered
  • line 71: getAgentVersions(false) returns the original AgentVersionList array by reference, exposing a mutable global configuration to external code. Callers can push/pop, splice, or mutate entries (including auto flags and the Agent/MessageContext properties), causing future calls (e.g., getActiveAgentVersion) to behave unpredictably (empty list, out-of-bounds, or mismatched version data). This violates invariants and permits hard-to-debug runtime errors. [ Low confidence ]

@humanagent humanagent merged commit 24fcb02 into main Nov 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants