Update agent-sdk versions #1530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update agent integrations to default to
@xmtp/agent-sdk1.1.10 and restrictAgent.createFromEnvinagents/bots/key-check/index.tstoActionsCodecandIntentCodecBump the default agent SDK to 1.1.10 with updated version mappings and adjust the key-check bot to register only
ActionsCodecandIntentCodec, while adding sender address logging in theagent.on('text')handler.📍Where to Start
Start with the version map changes in agents/versions/agent-sdk.ts, then review the
Agent.createFromEnvconfiguration andagent.on('text')handler in agents/bots/key-check/index.ts.📊 Macroscope summarized 3bb4928. 2 files reviewed, 4 issues evaluated, 3 issues filtered, 0 comments posted
🗂️ Filtered Issues
agents/bots/key-check/index.ts — 0 comments posted, 2 evaluated, 2 filtered
codecsarray was reduced to[new ActionsCodec(), new IntentCodec()], removing previously supported codecsMarkdownCodec,ReactionCodec,ReplyCodec,RemoteAttachmentCodec,AttachmentCodec, andWalletSendCallsCodec. If the agent receives or needs to emit messages using any of these content types (which were previously supported), it will be unable to decode/encode them. Depending onAgent.createFromEnvand the agent's message handling pipeline, this can result in runtime failures such as unrecognized content type errors, dropped messages, or failure to process basic text/markdown messages. This is a visible behavior change and breaks parity with the earlier externally visible contract for supported content types. [ Low confidence ]Agent.createFromEnvexpects a baseline text/markdown codec to be present (for system messages, fallbacks, or default decoding), reducingcodecsto onlyActionsCodecandIntentCodeccan cause agent startup to fail or lead to exceptions when processing basic messages. This is a plausible runtime bug given the previously includedMarkdownCodec. [ Low confidence ]agents/versions/agent-sdk.ts — 0 comments posted, 2 evaluated, 1 filtered
getAgentVersions(false)returns the originalAgentVersionListarray by reference, exposing a mutable global configuration to external code. Callers can push/pop, splice, or mutate entries (includingautoflags and theAgent/MessageContextproperties), causing future calls (e.g.,getActiveAgentVersion) to behave unpredictably (empty list, out-of-bounds, or mismatched version data). This violates invariants and permits hard-to-debug runtime errors. [ Low confidence ]