Skip to content

Conversation

@peinearydevelopment
Copy link
Contributor

#104 I would really like to see this feature as well. From my understanding of your comments, these changes are what is necessary to enable it. Please accept this contribution to enable the feature or let me know what else needs to get done to enable it.

Thanks for creating such a great/useful library!!!

@xoofx
Copy link
Owner

xoofx commented Sep 12, 2017

Hi, unfortunately, I can't accept this PR. After thinking about it, changing the behavior of the Html renderer to not render Html at all is not a good direction (note that the EnableHtmlForInline was introduced to support a required feature of rendering nodes without decoration inside links)

The reason is that in order to support #104, I would much prefer that we do this work as part of #32, as it covers broader use cases.

(Sorry, I'm realizing that I was giving the advise in #104 to add the EnableHtmlForBlock 😅 which is in fact not really a great option... but probably not the worse, after all... let me think about it)

@peinearydevelopment
Copy link
Contributor Author

Thanks for the feedback. That is a little disappointing though as this is for a project I'm currently in the middle of. Please let me know if there is something else I can do to help with this!

@xoofx
Copy link
Owner

xoofx commented Sep 12, 2017

That is a little disappointing

As I said above, making this as part of the html renderer might not be the worse solution after all. 😉 I just need a bit of time to take a look at the details...

@xoofx xoofx merged commit 70c4f6d into xoofx:master Oct 24, 2017
@xoofx
Copy link
Owner

xoofx commented Oct 24, 2017

Thanks, I have merged these changes to master

@peinearydevelopment
Copy link
Contributor Author

Thank you for all of your hard work on this library. It is greatly appreciated!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants