Fixes issue where sentences containing strong emphasis words did not correctly delimit the strong tag #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly delimit the strong tag
xoofx
added a commit
that referenced
this pull request
Jul 30, 2016
Owner
|
Thanks a lot for this. I have added a test just to track this down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
Should result in:
But actually outputs:
Note: I haven't included a spec to demonstrate the fix, as the specs for this part comes from CommonMark. Would you prefer me to add a new spec to this pull request, or to submit a pull request to the CommonMark spec?