Random perf improvements #499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is the base type of every node on the AST, it amounts to ~3% allocated bytes reduction
Owner
|
Might wait to merge #481 before merging this one? |
Owner
|
And, oh, thank you again, impressed that you still find the time to improve here and there some performance items! 😃 |
Collaborator
Author
|
Yeah this one should wait to avoid more merge conflicts. I will look at #481 today |
Collaborator
Author
|
Closing this due to all the conflicts - will open new PRs including ideas from this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen tweaks and allocation improvements.
Removing the overheads in the simple
Markdown.ToHtml(...)case with the default pipeline.For an empty string allocations go from 17.14 KB to 928 B and take 1/20th the time because of the default pipeline caching (2af8b1f) - means we're now benefiting from the Renderer caching from afe4308 in the basic use cases.
For c776d18 I was quite surprised how bad the compiler is at avoiding these allocations :/