Closed
Conversation
MihaZupan
reviewed
Dec 3, 2021
Collaborator
MihaZupan
left a comment
There was a problem hiding this comment.
Seems reasonable to me to extend the context to rendering
| pipeline ??= DefaultPipeline; | ||
|
|
||
| using var rentedRenderer = pipeline.RentHtmlRenderer(); | ||
| using var rentedRenderer = pipeline.RentHtmlRenderer(null, context); |
Collaborator
There was a problem hiding this comment.
Suggested change
| using var rentedRenderer = pipeline.RentHtmlRenderer(null, context); | |
| using var rentedRenderer = pipeline.RentHtmlRenderer(writer: null, context); |
| private readonly MarkdownParserContext? _context; | ||
|
|
||
| public HtmlRendererCache(MarkdownPipeline pipeline, bool customWriter = false) | ||
| public HtmlRendererCache(MarkdownPipeline pipeline, bool customWriter = false, MarkdownParserContext? context = null) |
Collaborator
There was a problem hiding this comment.
The MarkdownParserContext may be different for each parsing operation and shouldn't be cached between uses of the renderer.
Instead of storing the context on HtmlRendererCache, set it after renting it like we do with the writer and then null it out in Reset.
Contributor
Author
|
I get you, it turned out to be a little more complicated than I thought. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added MarkdownParserContext to Renderer.
I wrote my own LinkExtension render
TryLinkInlineRenderer, and need context access fromHtmlRenderer, that available only in parser.I think the context should be available both in the parser and in the render. This required minimal changes.
What do you think?