Fix emoji not rendering in table cells#928
Merged
xoofx merged 3 commits intoxoofx:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Emoji extension’s inline matching rules so emoji shortcodes can render inside pipe table cells (e.g., |:x:|), addressing #807.
Changes:
- Relaxed the “previous character” boundary check in
EmojiParser.Matchto allow emoji matches after non-alphanumeric characters. - Added NUnit regression tests covering emoji rendering in pipe tables and non-matching cases when preceded by letters/digits.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Markdig/Extensions/Emoji/EmojiParser.cs | Expands emoji boundary conditions to allow parsing after non-letter/digit characters (e.g., table cell ` |
| src/Markdig.Tests/TestCustomEmojis.cs | Adds regression tests for emoji rendering behavior within pipe tables. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
Good catch! Indeed, this is something that should be fixed, thank you! |
This was referenced Mar 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added
char.IsLetterOrDigitto the character check inEmojiParser.Match.It enables rendering for emoji patterns like
|:x:|.#807