refactor regulation list#4
Open
bryelandt wants to merge 1 commit into
Open
Conversation
Owner
|
Sent you an email, sorry for the delay |
xoolive
reviewed
Nov 21, 2024
| from pyb2b.types.generated.flow import ( | ||
| RegulationListReply, | ||
| RegulationListRequest, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the regulation list following the flight requests.
I think there is a few work left on the typing side.
It also removes the build_df method which I find very useful so it might be interesting to keep it. I wanted to double check with you for the architecture of the package if we want to keep it, where it should be placed.