Add finite difference and sample options to LBFGS#337
Closed
nikitakuklev wants to merge 12 commits intoxopt-org:mainfrom
Closed
Add finite difference and sample options to LBFGS#337nikitakuklev wants to merge 12 commits intoxopt-org:mainfrom
nikitakuklev wants to merge 12 commits intoxopt-org:mainfrom
Conversation
nikitakuklev
force-pushed
the
nogradopt
branch
from
9fe26fa to
4daf5c7
Compare
nikitakuklev
force-pushed
the
nogradopt
branch
from
51a49a8 to
c5bcdf2
Compare
Collaborator
Author
|
This PR is no longer applicable since LBFGS settings will be moved to a separate object in 3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
with_grad, which is passed down to scipy method. BoTorch automatically useswith torch.no_grad(), so we don't need to disable gradients ourselves. Using finite differences, non-differentiable operations can be handled reasonably.Re-added
n_raw_samples- this is supposed to be a helpful feature to ensure that restarts begin on good points. It was removed awhile back, not sure why.