feat: add collapsible sidebar with persistent state#4906
Merged
Conversation
Add collapse/expand toggle to the sidebar navigation. The collapsed state is persisted in localStorage so it survives page reloads. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request implements a collapsible sidebar for the web UI, featuring state persistence via local storage and responsive width adjustments. The review feedback highlights a few technical improvements: ensuring the setState updater function remains pure by moving side effects outside, correcting a CSS transition limitation where height: auto hinders animations, and addressing missing localization keys for the new toggle button tooltips.
qinxuye
reviewed
May 13, 2026
Contributor
qinxuye
left a comment
There was a problem hiding this comment.
Reviewed the sidebar collapse change and left one inline comment for a small i18n issue.
- Make toggleCollapsed a pure function by moving writeCollapsed outside setState - Replace height:auto with maxHeight for working CSS transition - Add menu.expand/collapse keys to all locale files (en/zh/ja/ko) - Remove dead || fallbacks from tooltip text Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan