WIP: Use GtkGridView for albums #480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GtkGridView requires its immediate parent to be GtkScrolledWindow to have correct information about available space. Being a child of GtkOverlay causes the scrolled window to be of the wrong size.
GtkGridView requires its immediate parent to be GtkScrolledWindow to have correct information about available space. Being a child of GtkOverlay causes the scrolled window to be of the wrong size.
Owner
|
Hi! Sorry for the slow response. This sounds like a nice improvement! I'll check out that branch and have a look. Thnaks for working on this! |
Collaborator
|
@martymichal can you rebase against maintenance please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at moving away from FlowBox to GridView for album lists. Has some rough edges (e.g., layout, stylesheet) but is usable enough. Some commits might be needed to be removed as GridView is not usable everywhere.
Is this the way to go?