Storing input streams

[thekid]

The following works as expected:

use io\File;
use io\archive\zip\ZipFile;
use io\streams\Streams;
use util\cmd\Console;

$entries= [];
$z= ZipFile::open(new File($argv[1]));
foreach ($z->entries() as $entry) {
  if ($entry->isDirectory()) {
    // Create dir
  } else {
    Console::writeLine($entry->getName(), ' (', $entry->getSize(), ' bytes)');
    $entries[$entry->getName()]= $entry;
  }
}

if ($file= ($argv[2] ?? null)) {
  Console::writeLine($file, ' => `', Streams::readAll($entries[$file]->in()), '`');
}

However, if the script above is changed to store the input streams instead of the entry references as follows:

--- unzip.script.php.orig       2026-04-18 11:01:02.939946100 +0200
+++ unzip.script.php    2026-04-18 11:01:09.531390500 +0200
@@ -12,10 +12,10 @@
     // Create dir
   } else {
     Console::writeLine($entry->getName(), ' (', $entry->getSize(), ' bytes)');
-    $entries[$entry->getName()]= $entry;
+    $entries[$entry->getName()]= $entry->in();
   }
 }

 if ($file= ($argv[2] ?? null)) {
-  Console::writeLine($file, ' => `', Streams::readAll($entries[$file]->in()), '`');
+  Console::writeLine($file, ' => `', Streams::readAll($entries[$file]), '`');
 }

...reading the file contents yields the bytes \024\v\n\000 instead of the file content.

[thekid]

Potential fix:

diff --git a/src/main/php/io/archive/zip/ZipFileInputStream.class.php b/src/main/php/io/archive/zip/ZipFileInputStream.class.php
index a9e050ba..10e86b13 100755
--- a/src/main/php/io/archive/zip/ZipFileInputStream.class.php
+++ b/src/main/php/io/archive/zip/ZipFileInputStream.class.php
@@ -49,6 +49,7 @@ class ZipFileInputStream implements InputStream, Seekable {
    * @return string
    */
   public function read($limit= 8192) {
+    $this->reader->streamPosition($this->start + $this->pos);
     $chunk= $this->reader->streamRead(min($limit, $this->length - $this->pos));
     $l= strlen($chunk);
     $this->pos+= $l;

Question is whether passing the offset should be part of streamRead(), reducing the function calls.

[thekid]

Released in https://github.com/xp-framework/zip/releases/tag/v11.3.2