Skip to content

Enterprise appendix#13

Merged
ben merged 9 commits into
masterfrom
enterprise-appendix
May 21, 2015
Merged

Enterprise appendix#13
ben merged 9 commits into
masterfrom
enterprise-appendix

Conversation

@ben
Copy link
Copy Markdown
Collaborator

@ben ben commented May 11, 2015

This adds an appendix to cover GitHub Enterprise.

  • Write the appendix

Comment thread appendix-enterprise.asciidoc Outdated
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of wondering if this section is necessary. A summary is nice for a prose chapter, and as a transition to another one, but an Appendix doesn't really need any of that ceremony. I also notice that none of the other appendices have them. What do you think?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ask Meghan. I think everything you wrote here sets the stage for enterprise. I think we should remove the pricing section; it is probably something that could change before the book is published and does not contribute to the "advanced" theme as much. Other than that, this is good stuff.

@ben
Copy link
Copy Markdown
Collaborator Author

ben commented May 15, 2015

OK, I reworded some things and made it a bit smoother. What do you think?

@xrd
Copy link
Copy Markdown
Owner

xrd commented May 16, 2015

I think it would be interesting to discuss how different advanced tools work. For example, show how hub works with the enterprise server. Show an example of the ruby library configured to use the API from the enterprise server. And perhaps show how the network topology could be made more secure if services are all hosted inside the firewall. I'm not making a request for you to do all this, ben, just noting it as something for me to follow up on.

@ben
Copy link
Copy Markdown
Collaborator Author

ben commented May 21, 2015

Migrated the TODO into its own issue. I'm going to merge this for now, feel free to edit as you see fit.

ben added a commit that referenced this pull request May 21, 2015
@ben ben merged commit c9d497b into master May 21, 2015
@ben ben deleted the enterprise-appendix branch May 21, 2015 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants