Open
Conversation
… LogsSample support, remove raw_document - Migrate E2E from deprecated @grafana/e2e (Cypress) to @grafana/plugin-e2e (Playwright) - Add field selection/filtering UI in the log query editor (MultiSelect picker) - Add LogsSample supplementary query support for sample log lines alongside metric queries - Remove deprecated raw_document query type from frontend and backend - Update CI workflow to install Playwright browsers https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
The previous commit removed @grafana/e2e but DataSourcePicker.tsx still imports from @grafana/e2e-selectors. While the package exists as a transitive dependency, TypeScript needs it declared directly for type resolution. https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
The isRawDataQuery function only checked for "raw_data" type but tests also use "raw_document" type, causing "invalid query, missing metrics and aggregations" errors. https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
raw_document returns whole documents as single JSON blobs, while raw_data flattens documents into individual columns. These need separate response processors. https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@grafana/toolkitto@grafana/create-plugintoolchainTest plan
npm run buildsucceedsnpm run testpasseshttps://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS