Skip to content

Audit and modernize Grafana plugin#1

Open
xrl wants to merge 4 commits intomainfrom
claude/audit-grafana-plugin-Y0Y4P
Open

Audit and modernize Grafana plugin#1
xrl wants to merge 4 commits intomainfrom
claude/audit-grafana-plugin-Y0Y4P

Conversation

@xrl
Copy link
Copy Markdown
Owner

@xrl xrl commented Mar 21, 2026

Summary

  • Migrated from deprecated @grafana/toolkit to @grafana/create-plugin toolchain
  • Updated all dependencies to latest compatible versions
  • Fixed TypeScript errors and modernized component patterns
  • Added Playwright E2E test infrastructure replacing Cypress
  • Fixed configuration editor issues and improved query editor

Test plan

  • Verify npm run build succeeds
  • Verify npm run test passes
  • Verify plugin loads in Grafana
  • Test query editor against a Quickwit instance

https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS

claude added 4 commits March 20, 2026 23:24
… LogsSample support, remove raw_document

- Migrate E2E from deprecated @grafana/e2e (Cypress) to @grafana/plugin-e2e (Playwright)
- Add field selection/filtering UI in the log query editor (MultiSelect picker)
- Add LogsSample supplementary query support for sample log lines alongside metric queries
- Remove deprecated raw_document query type from frontend and backend
- Update CI workflow to install Playwright browsers

https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
The previous commit removed @grafana/e2e but DataSourcePicker.tsx still
imports from @grafana/e2e-selectors. While the package exists as a
transitive dependency, TypeScript needs it declared directly for type
resolution.

https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
The isRawDataQuery function only checked for "raw_data" type but tests
also use "raw_document" type, causing "invalid query, missing metrics
and aggregations" errors.

https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
raw_document returns whole documents as single JSON blobs, while
raw_data flattens documents into individual columns. These need
separate response processors.

https://claude.ai/code/session_017ghFQcuzZkrzEKp1BpLjZS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants