Skip to content

fix: remove erc20types duplicate#118

Merged
AdriaCarrera merged 1 commit into
mainfrom
fix/erc20-module-duplicate
May 13, 2026
Merged

fix: remove erc20types duplicate#118
AdriaCarrera merged 1 commit into
mainfrom
fix/erc20-module-duplicate

Conversation

@kpitapeersyst

@kpitapeersyst kpitapeersyst commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

fix: remove erc20types duplicate

Motivation 💡

erc20types.ModuleName was listed twice in genesisModuleOrder in app/app.go. Cosmos SDK's module manager rejects duplicate module names when setting init/export genesis order, which would fail on node startup.

Changes 🛠

  • Removed the duplicate erc20types.ModuleName entry from genesisModuleOrder in app/app.go (the canonical entry earlier in the list is preserved)

Summary by CodeRabbit

  • Chores
    • Adjusted ERC20 module ordering during genesis initialization and export to optimize the sequence of module operations during blockchain initialization and state export.

@coderabbitai

coderabbitai Bot commented Apr 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: da3a7bbe-6688-4355-a076-4d39d191e955

📥 Commits

Reviewing files that changed from the base of the PR and between 43c1c36 and 0c5c762.

📒 Files selected for processing (1)
  • app/app.go
💤 Files with no reviewable changes (1)
  • app/app.go

📝 Walkthrough

Walkthrough

The PR removes erc20types.ModuleName from the genesisModuleOrder slice in app/app.go, modifying the sequence in which the ERC20 module initializes and exports its genesis state relative to other modules.

Changes

Cohort / File(s) Summary
Genesis Module Ordering
app/app.go
Removed ERC20 module from genesis initialization and export ordering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A module departs from genesis's grand dance,
ERC20 steps back—a strategic stance.
One line removed, the order rearranged,
The blockchain's heartbeat, gently estranged. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing a duplicate erc20types entry from the genesis module order.
Description check ✅ Passed The description covers motivation and changes sections clearly. The Dependencies section is omitted, which is acceptable as it's not critical when no external dependencies exist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/erc20-module-duplicate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit 433499b into main May 13, 2026
6 checks passed
@AdriaCarrera AdriaCarrera deleted the fix/erc20-module-duplicate branch May 13, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants