Skip to content

fix: include v7-v10 upgrades in store upgrades switch#129

Merged
AdriaCarrera merged 1 commit into
mainfrom
fix/include-all-upgrades-store-switch
May 13, 2026
Merged

fix: include v7-v10 upgrades in store upgrades switch#129
AdriaCarrera merged 1 commit into
mainfrom
fix/include-all-upgrades-store-switch

Conversation

@kpitapeersyst

@kpitapeersyst kpitapeersyst commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

fix: include v7-v10 upgrades in store upgrades switch

Motivation 💡

The store upgrades switch in setupUpgradeHandlers only matched v5 and v6, so reaching the v7, v8, v9, or v10 upgrade heights would not assign an empty StoreUpgrades and the store loader would never be configured for those plans. All registered upgrade handlers should be reflected in the switch.

Changes 🛠

  • Added v7.UpgradeName, v8.UpgradeName, v9.UpgradeName, and v10.UpgradeName to the switch upgradeInfo.Name block in app/upgrades.go so they share the same empty StoreUpgrades path as v5/v6

Summary by CodeRabbit

  • Chores
    • Extended support for additional upgrade versions in the application upgrade process.

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 397a8f43-042a-4685-b83e-15081d54c8b9

📥 Commits

Reviewing files that changed from the base of the PR and between 43c1c36 and 2f305b4.

📒 Files selected for processing (1)
  • app/upgrades.go

📝 Walkthrough

Walkthrough

The change extends store upgrade handling initialization logic in setupUpgradeHandlers to cover upgrade versions v5 through v10, broadening the range of planned upgrade names that trigger store upgrade handling application during module setup.

Changes

Cohort / File(s) Summary
Store Upgrade Version Expansion
app/upgrades.go
Extended storeUpgrades initialization to apply store upgrade handling for upgrade versions v5 through v10, expanding from the previous v5 and v6 coverage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hoppy upgrades, version by version,
From five to ten, each one's assertion,
Store loaders leap through the chain,
Thumping along with never a strain! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding v7-v10 upgrades to the store upgrades switch statement. It is concise, specific, and clearly communicates the primary modification.
Description check ✅ Passed The PR description follows the required template with complete Motivation and Changes sections. It clearly explains why the change was needed and what was modified, meeting the repository's documentation standards.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/include-all-upgrades-store-switch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit fd88030 into main May 13, 2026
6 checks passed
@AdriaCarrera AdriaCarrera deleted the fix/include-all-upgrades-store-switch branch May 13, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants