fix: include v7-v10 upgrades in store upgrades switch#129
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change extends store upgrade handling initialization logic in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fix: include v7-v10 upgrades in store upgrades switch
Motivation 💡
The store upgrades switch in
setupUpgradeHandlersonly matchedv5andv6, so reaching thev7,v8,v9, orv10upgrade heights would not assign an emptyStoreUpgradesand the store loader would never be configured for those plans. All registered upgrade handlers should be reflected in the switch.Changes 🛠
v7.UpgradeName,v8.UpgradeName,v9.UpgradeName, andv10.UpgradeNameto theswitch upgradeInfo.Nameblock inapp/upgrades.goso they share the same emptyStoreUpgradespath as v5/v6Summary by CodeRabbit