Skip to content

fix: align cosmossdk core requirement#134

Merged
AdriaCarrera merged 1 commit into
mainfrom
fix/cosmossdk-core-version
May 13, 2026
Merged

fix: align cosmossdk core requirement#134
AdriaCarrera merged 1 commit into
mainfrom
fix/cosmossdk-core-version

Conversation

@kpitapeersyst
Copy link
Copy Markdown
Contributor

@kpitapeersyst kpitapeersyst commented May 4, 2026

fix: align cosmossdk core requirement

Motivation 💡

  • Remove the silent cosmossdk.io/core downgrade where go.mod required v0.12.0 but resolved v0.11.3 through a replace directive.
  • Avoid depending on cosmossdk.io/core v0.12.0, which is retracted and incompatible with the Cosmos SDK fork used by this repository.

Changes 🛠

  • Changed the direct cosmossdk.io/core requirement from v0.12.0 to v0.11.3.
  • Removed the stale cosmossdk.io/core => cosmossdk.io/core v0.11.3 replace directive and rosetta workaround comment.

Considerations 🤔

  • go list -m -json -retracted cosmossdk.io/core@v0.12.0 reports that v0.12.0 was tagged too early and is incompatible with Cosmos SDK v0.50.
  • v0.12.0 renames comet.BlockInfo to comet.Info, which breaks the current github.com/xrplevm/cosmos-sdk v0.53.6-xrplevm.1 dependency.

Summary by CodeRabbit

  • Chores
    • Updated dependencies for improved compatibility and stability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce4e446a-5c43-46f4-885b-20cf5bfdc198

📥 Commits

Reviewing files that changed from the base of the PR and between 43c1c36 and 46d7742.

📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

Updated cosmossdk.io/core dependency from v0.12.0 to v0.11.3 in the main require block and removed the now-redundant replace directive override that previously pinned the same version.

Changes

Dependency Version & Override Cleanup

Layer / File(s) Summary
Version Specification
go.mod
cosmossdk.io/core downgraded from v0.12.0 to v0.11.3 in the main require block.
Override Cleanup
go.mod
Removed the replace directive entry for cosmossdk.io/core => cosmossdk.io/core v0.11.3 since the required version now matches.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • AdriaCarrera

Poem

🐰 A version takes a step back, neat and tidy,
The override fades—no more duplication.
One source of truth in go.mod we find,
Simpler paths through the warren we bind!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: align cosmossdk core requirement' directly and clearly summarizes the main change: updating the cosmossdk.io/core dependency version and removing an outdated replace directive.
Description check ✅ Passed The PR description fully addresses all required template sections: Motivation clearly explains the problem, Changes detail the modifications made, and Considerations provide important context about version incompatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cosmossdk-core-version

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit 27a8748 into main May 13, 2026
6 checks passed
@AdriaCarrera AdriaCarrera deleted the fix/cosmossdk-core-version branch May 13, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants