Skip to content

fix: register poa params subspace#138

Merged
AdriaCarrera merged 1 commit into
mainfrom
fix/register-poa-subspace
May 18, 2026
Merged

fix: register poa params subspace#138
AdriaCarrera merged 1 commit into
mainfrom
fix/register-poa-subspace

Conversation

@kpitapeersyst
Copy link
Copy Markdown
Contributor

@kpitapeersyst kpitapeersyst commented May 4, 2026

fix: register poa params subspace

Motivation 💡

  • POA module params subspace was not registered in paramsKeeper, leaving the module without its expected params storage namespace.

Changes 🛠

  • Register poatypes.ModuleName subspace on paramsKeeper in app/app.go

Summary by CodeRabbit

  • Chores
    • Improved PoA module initialization by setting up parameter configuration during keeper setup.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bb790b1d-b4df-4f7d-9bf0-9a3e8b9966d7

📥 Commits

Reviewing files that changed from the base of the PR and between 43c1c36 and 89cd6c2.

📒 Files selected for processing (1)
  • app/app.go

📝 Walkthrough

Walkthrough

The PoA module parameter subspace is now initialized during keeper setup by adding a single paramsKeeper.Subspace(poatypes.ModuleName) call within initParamsKeeper.

Changes

PoA Module Parameter Registration

Layer / File(s) Summary
Keeper Initialization
app/app.go
initParamsKeeper registers a parameter subspace for the PoA module alongside existing subspace registrations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little param space so fine,
For PoA keepers to align,
One line of code, so pure and true,
Makes module initialization new! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: register poa params subspace' clearly and directly summarizes the main change: registering a parameter subspace for the POA module.
Description check ✅ Passed The PR description includes Motivation and Changes sections that directly address the issue and explain the fix. While the Considerations and Dependencies sections are omitted, they are not critical for this straightforward fix.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/register-poa-subspace

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit a8c27f1 into main May 18, 2026
6 checks passed
@AdriaCarrera AdriaCarrera deleted the fix/register-poa-subspace branch May 18, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants