Skip to content

fix: remove test grpc service#140

Merged
AdriaCarrera merged 1 commit into
mainfrom
fix/remove-test-grpc-service
May 13, 2026
Merged

fix: remove test grpc service#140
AdriaCarrera merged 1 commit into
mainfrom
fix/remove-test-grpc-service

Conversation

@kpitapeersyst
Copy link
Copy Markdown
Contributor

@kpitapeersyst kpitapeersyst commented May 4, 2026

fix: remove test grpc service

Motivation 💡

  • The production app constructor registered github.com/cosmos/cosmos-sdk/testutil/testdata/testpb on the live gRPC query router. That package is an SDK test utility and should not be exposed by production nodes.

Changes 🛠

  • Removed the testdata_pulsar import from app/app.go.
  • Removed the testdata_pulsar.RegisterQueryServer(...) call from New().

Summary by CodeRabbit

  • Bug Fixes
    • Removed test service registration from app initialization, preventing unnecessary test components from being loaded during runtime.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3c230325-2b26-4111-9f37-b0963c17a519

📥 Commits

Reviewing files that changed from the base of the PR and between 43c1c36 and bbcf8ee.

📒 Files selected for processing (1)
  • app/app.go
💤 Files with no reviewable changes (1)
  • app/app.go

📝 Walkthrough

Walkthrough

The PR removes the testdata_pulsar test gRPC service registration from app initialization, deleting its import and the corresponding RegisterQueryServer call from the app setup routine.

Changes

Test Infrastructure Cleanup

Layer / File(s) Summary
Import Removal
app/app.go (line 78)
Deleted the testdata_pulsar import from github.com/cosmos/cosmos-sdk/testutil/testdata/testpb.
Service Registration Removal
app/app.go (line 784)
Removed the testdata_pulsar.RegisterQueryServer() call that registered the test query server on app.GRPCQueryRouter() during initialization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A test gRPC service departs,
No longer cluttering startup charts,
The testdata_pulsar takes its bow,
Leaving app initialization cleaner now! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing a test gRPC service from the production app constructor.
Description check ✅ Passed The description covers the required sections with clear motivation and changes; the Considerations and Dependencies sections are appropriately omitted as non-critical.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-test-grpc-service

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit 3590d61 into main May 13, 2026
6 checks passed
@AdriaCarrera AdriaCarrera deleted the fix/remove-test-grpc-service branch May 13, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants