Skip to content

feat: set staking unbonding time to one week in v11 upgrade#145

Merged
AdriaCarrera merged 2 commits into
xrplevm:mainfrom
aluque-peersyst:feat/set-unbonding-time-to-one-week-in-v11
Jun 22, 2026
Merged

feat: set staking unbonding time to one week in v11 upgrade#145
AdriaCarrera merged 2 commits into
xrplevm:mainfrom
aluque-peersyst:feat/set-unbonding-time-to-one-week-in-v11

Conversation

@aluque-peersyst

@aluque-peersyst aluque-peersyst commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Increase staking unbonding time to one week in v11 from the current 1 day

Summary by CodeRabbit

  • Upgrades
    • V11 upgrade now automatically configures staking parameters, setting the unbonding period to 7 days during the migration process.
  • Maintenance
    • Expanded the v11 upgrade handler’s required dependencies to include staking parameter access.
    • Minor test and dependency-list cleanups (mock import path, go.mod ordering).

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 887c972f-c6b2-455a-9373-29508f666476

📥 Commits

Reviewing files that changed from the base of the PR and between f0ab218 and 1fa02fc.

📒 Files selected for processing (2)
  • go.mod
  • x/poa/keeper/msg_server_remove_validator_test.go
✅ Files skipped from review due to trivial changes (1)
  • go.mod

📝 Walkthrough

Walkthrough

The v11 upgrade handler is extended to update the staking module's UnbondingTime to 7 days. A StakingKeeper interface is added to the v11 keepers file, CreateUpgradeHandler receives a new stakingKeeper parameter, the handler fetches and persists updated staking params, and app.StakingKeeper is passed at the wiring site.

Changes

v11 Staking UnbondingTime Update

Layer / File(s) Summary
StakingKeeper interface and upgrade handler logic
app/upgrades/v11/keepers.go, app/upgrades/v11/upgrades.go
Defines StakingKeeper with GetParams/SetParams over stakingtypes.Params, adds stakingKeeper StakingKeeper to CreateUpgradeHandler's signature, imports the time package, and implements the fetch-update-persist logic setting UnbondingTime to 7 * 24 * time.Hour inside the v11 handler.
App-level wiring
app/upgrades.go
Passes app.StakingKeeper into v11.CreateUpgradeHandler within setupUpgradeHandlers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • xrplevm/node#127: Modifies the same v11 upgrade plumbing files (app/upgrades.go and app/upgrades/v11/upgrades.go) to extend CreateUpgradeHandler, specifically adding the ICA host keeper and disabling the ICA host module in the handler.

Poem

🐇 Hop hop, the unbonding days are set,
Seven days to wait — the shortest bet!
A keeper defined, its params in hand,
The upgrade handler shifts param land.
With one small wire, the chain obeys —
The rabbit writes params, then hops away! 🌟

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description is minimal and lacks the structured sections defined in the template (Motivation, Changes, Considerations, Dependencies), though it does briefly convey the core change. Expand the description to include Motivation (why this change), detailed Changes (list all modifications), and any Considerations (impacts or warnings) as specified in the template.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely describes the main change: setting the staking unbonding time to one week in the v11 upgrade, which matches the core functionality across all modified files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera AdriaCarrera merged commit 3dd4f87 into xrplevm:main Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants