postgres: change backup format from plain SQL to pg_dump custom #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm experimenting with implementing the backup restore step and I ran into a few complications: * pg_restore does not like plain SQL and prefers this format they refer to as "custom" * psql does not allow us to change the role to `xsnippet-api` before restoring the backup in an Ansible task, so all objects end up being owned by the admin role `postgres`... And we can't use `become` because the system user `xsnippet-api` does not exist at that point yet Switching to the custom format allows us to have this symmetry between pg_dump and pg_restore, and preserve/restore the correct owner value on all database objects. pg_restore also allows to skip the commands setting ownership, e.g. if we want to migrate to a different role.
malor
force-pushed
the
backup-format
branch
from
1930a4c to
976b4e4
Compare
ikalnytskyi
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experimenting with implementing the backup restore step and I ran into a few complications:
pg_restore does not like plain SQL and prefers this format they refer to as "custom"
psql does not allow us to change the role to
xsnippet-apibefore restoring the backup in an Ansible task, so all objects end up being owned by the admin rolepostgres... And we can't usebecomebecause the system userxsnippet-apidoes not exist at that point yetSwitching to the custom format allows us to have this symmetry between pg_dump and pg_restore, and preserve/restore the correct owner value on all database objects. pg_restore also allows to skip the commands setting ownership, e.g. if we want to migrate to a different role.