Use builtin uglifyjs-webpack-plugin #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far XSnippet Web depends on uglify-webpack-plugin v1.0.1 that depends on uglify-es v3.1.3 but since the latter is added to dependencies with ^ mark it means we can use any minor version (i.e. any 3.x). Unfortunately, uglify-es 3.3.0+ (released 2 days ago) broke something and any minified build currently produced doesn't work and fail with JS errors in browser console. One way to fix it is to try to pin uglify-es to latest working version which is v3.2.2. Another is to use builtin uglify-webpack-plugin which is old (v0.4.2). This commit implements the latter approach and use builtin version instead. The rationale is simple: there's no need to use latest version and we are more than happy with tested bundled version. :)
lotrien
approved these changes
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far XSnippet Web depends on uglify-webpack-plugin v1.0.1 that depends
on uglify-es v3.1.3 but since the latter is added to dependencies with ^
mark it means we can use any minor version (i.e. any 3.x).
Unfortunately, uglify-es 3.3.0+ (released 2 days ago) broke something
and any minified build currently produced doesn't work and fail with JS
errors in browser console. One way to fix it is to try to pin uglify-es
to latest working version which is v3.2.2. Another is to use builtin
uglify-webpack-plugin which is old (v0.4.2).
This commit implements the latter approach and use builtin version
instead. The rationale is simple: there's no need to use latest version
and we are more than happy with tested bundled version. :)