Set output publicPath in webpack.config.js #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'output.publicPath' is not specified in webpack.config.js, it's assumed that all produced assets (CSS, JS, images) are in the same directory. That means produced 'index.html' will look for them relative to itself. While this is not a problem on its own, it's a problem when one have nested routes in the application. For instance, if someone will try to open some path, say, /foo/bar/baz the webserver will respond with 'index.html' that will look for assets in current directory which is /foo/bar/baz. Obviously, there no such directory so the webserver won't be able to respond with JS/CSS. Fortunately, it could be fixed by settings 'output.publicPath' option that should be considered as a path to assets. When it's set to '/' the assets will be looked at root domain no matter which path was passed in URI. [1] https://webpack.js.org/guides/public-path/
lotrien
approved these changes
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'output.publicPath' is not specified in webpack.config.js, it's
assumed that all produced assets (CSS, JS, images) are in the same
directory. That means produced 'index.html' will look for them relative
to itself.
While this is not a problem on its own, it's a problem when one have
nested routes in the application. For instance, if someone will try to
open some path, say,
/foo/bar/baz
the webserver will respond with 'index.html' that will look for assets
in current directory which is /foo/bar/baz. Obviously, there no such
directory so the webserver won't be able to respond with JS/CSS.
Fortunately, it could be fixed by settings 'output.publicPath' option
that should be considered as a path to assets. When it's set to '/'
the assets will be looked at root domain no matter which path was passed
in URI.
[1] https://webpack.js.org/guides/public-path/