Adapt project to various environments (windows and jetbrains IDE's) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalnytskyi
reviewed
Jan 3, 2018
.gitignore
Outdated
| # misc | ||
| .DS_Store | ||
| npm-debug.log | ||
| /.idea |
Member
There was a problem hiding this comment.
Good practice is to have a newline at end of file. You see, Git warns you about this. :) Could you please add a proper option for .editorconfig to ensure it? :)
Seems like this one:
insert_final_newline = true
Member
There was a problem hiding this comment.
And then save file once again to make sure newline is inserted here and Git doesn't show a warning.
Contributor
Author
There was a problem hiding this comment.
Updated with new line and proper option in .editorconfig
ikalnytskyi
reviewed
Jan 3, 2018
| @@ -0,0 +1,6 @@ | |||
| # http://editorconfig.org | |||
Member
There was a problem hiding this comment.
Just wonder, does .editorconfig popular in JS world? It's rarely used in Python or any other world. :)
Contributor
Author
There was a problem hiding this comment.
Sure) You can see some of them here (eg react, webpack etc.)
AinuraAliieva
force-pushed
the
cross-env
branch
from
3d3d26f to
663bdc9
Compare
To allow developers working on project without any inconveniences. Different OS have handled line endings and environment variables differently. Also each IDE has system files that should not be in repository. So now we manage this points using cross-env package, .editorconfig and .gitignore. And we can working on project in different environments (such as windows and jetbrains IDE's)
AinuraAliieva
force-pushed
the
cross-env
branch
from
663bdc9 to
815d040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow developers working on project without any inconveniences.
Different OS have handled line endings and environment variables
differently. Also each IDE has system files that should not be in
repository. So now we manage this points using cross-env package,
.editorconfig and .gitignore. And we can working on project in
different environments (such as windows and jetbrains IDE's)