Use immutable.Map() as initial state for store #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use immutable.js classes in state to be protected from accidental state mutation. However, the protect is not complete as the root object is still plain Object() instance. So let's complete protection by using immutable.js Map as root object for state. Besides, having root state as immutable.js Map we make it easier to convert the whole state to plain JS in tests.
AinuraAliieva
approved these changes
Jan 4, 2018
lotrien
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use immutable.js classes in state to be protected from
accidental state mutation. However, the protect is not complete as the
root object is still plain Object() instance. So let's complete
protection by using immutable.js Map as root object for state.
Besides, having root state as immutable.js Map we make it easier to
convert the whole state to plain JS in tests.