Add unique attribute for tags and fixed keyPress issue #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid duplications for tags we've forbid tags duplications on component level, so user wouldn't be able to add two duplicate tags on new Snippet form. In addition, fixed onKeyPress issue so now it's not bubbling up to submit form element and thus do not cause form subbmitting when user tries to add new tag by clicking Enter button.
lotrien
force-pushed
the
keypress-unique
branch
from
959c9a5 to
c8699c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid duplications for tags we've forbid tags duplications
on component level, so user wouldn't be able to add two duplicate
tags on new Snippet form.
In addition, fixed onKeyPress issue so now it's not bubbling up
to submit form element and thus do not cause form subbmitting
when user tries to add new tag by clicking Enter button.