Update numpy version requirement for python 3.10+#101
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
guillon
requested changes
Jun 29, 2026
guillon
left a comment
Member
There was a problem hiding this comment.
Actually not the right solution, we require support for python 3.10+, hence the type checkers must assume python 3.10.
Member
Actually, the support for python 3.10 was dropped in numpy >=2.3, hence the right fix is to request numpy<2.3. Can you test this, you will have to modify both |
Contributor
Author
|
The CI passed with those changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CI does not work anymore with the error
Solution put the mypy python version to 3.12