Skip to content

test: fix issue with tarfile on macos/python 3.10#85

Merged
guillon merged 1 commit into
xtc-tools:mainfrom
guillon:dev/cguillon/ci-python
Jun 2, 2026
Merged

test: fix issue with tarfile on macos/python 3.10#85
guillon merged 1 commit into
xtc-tools:mainfrom
guillon:dev/cguillon/ci-python

Conversation

@guillon
Copy link
Copy Markdown
Member

@guillon guillon commented Jun 1, 2026

Motivation

Fix an issue introduced with PR #84 on macos/python 3.10

TarFile interface does not support filter argument for python 3.10.

Description

Implement wrapper for TarFile in xtc.utils.tarfile which tentatively forces format="data" or falls back to no format argument.

@guillon guillon self-assigned this Jun 1, 2026
@guillon guillon added the testing Add more test or rework in tests label Jun 1, 2026
@guillon guillon force-pushed the dev/cguillon/ci-python branch 2 times, most recently from 4b014ae to 0d6d002 Compare June 1, 2026 17:34
@guillon guillon enabled auto-merge June 1, 2026 17:36
@guillon guillon force-pushed the dev/cguillon/ci-python branch from 0d6d002 to 168095e Compare June 2, 2026 07:54
@guillon guillon merged commit 18a4e01 into xtc-tools:main Jun 2, 2026
3 checks passed
@guillon guillon deleted the dev/cguillon/ci-python branch June 2, 2026 08:03
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/xtc/utils/tarfile.py 45.45% 11 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Add more test or rework in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants