Merged
Conversation
…k in checkpoint: build-side spills to disk if it goes above a threshold, but then just reads it all back in checkpoint: only do hashing after spill checkpoint: write hashes out during shuffle shuffle/spill spill and shuffle out to their own isolated classes checkpoint: shuffle now pipes the data through too checkpoint: shuffle doing a shuffle checkpoint: Shuffle can reload a part at a time
This was referenced Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4592
This PR spills join build-sides to disk when they go over 100k rows.
Spillto write pages of the build-side to disk every time the accumulated relation goes over 100k rows. This writes one Arrow file, with one page for every 100k batch ('B' in total).DiskHashJoin(DHJ), otherwiseMemoryHashJoin(MHJ).main.It seems that other disk-based hash-join impls choose a partition count ahead-of-time, and then opt to re-partition if required. I elected not to write a dynamic re-partitioner, but it did mean for a slightly more complex alignment algo 😅