Preserve unknown area properties through edit/save cycle#2
Merged
Conversation
Contributor
jrv
commented
May 11, 2026
jrv
commented
Zod was stripping unrecognised fields (e.g. outline_count) from
area.properties at parse time, and AreaSettingsDialog was rebuilding
properties from scratch on save, dropping anything not explicitly listed.
Add .passthrough() to the properties sub-schema so unknown fields survive
parsing, and spread existing feature.properties before overwriting known
fields in AreaSettingsDialog.handleSave.
rovo89
requested changes
May 11, 2026
| type: z.enum(['mow', 'nav', 'obstacle', 'draft']).default('draft'), | ||
| active: z.boolean().default(true), | ||
| }), | ||
| }).passthrough(), |
Collaborator
There was a problem hiding this comment.
| const feature = draw.get(selectedIds[0])!; | ||
| const index = features.features.findIndex((f) => f.id === feature.id); | ||
| feature.properties = { | ||
| ...feature.properties, |
Collaborator
There was a problem hiding this comment.
I'm wondering if there could be an issue where some future, optional properties can't be unset anymore?!?
But generally, I agree that we want to keep additional properties, and obviously we don't know their keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.