xsimd install with xtensor dependency results in a broken CMake target file

[amyspark]

👋

I've just been told at Krita that Debian (and Ubuntu by extension)'s packaging of xsimd does not work to build Krita. I see in the Debian source that they're using -DENABLE_XTL_COMPLEX=ON to enable the xtl dependency, but in the xsimd-targets.cmake file, I read

add_library(xsimd INTERFACE IMPORTED)

set_target_properties(xsimd PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_std_14"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "xtl"
)

with absolutely no reference to xtl-targets.cmake or the relevant find_package line.

I'm not sure if this is a xsimd or Debian packaging issue, but reporting it FYI.

[JohanMabille]

Thanks for reporting! I think we should add the missing properties in the CMakeLists.txt when -DENABLE_XTL_COMPLEX=ON rather than in the targets file. However, the dependency on the xtl is already there.

[amyspark]

CMake doesn't generate find_package lines for dependencies, the project needs to generate its own Config template. I had the notes ready for a potential fix, but I fell sick and lost them...

[JohanMabille]

Actually the call to find_dependency(xtl) is done in the xsimdConfig.cmake file so I'm confused why Krita does not build with xsimd. I tried a local build of xtensor with a dependency on xsimd where ENABLE_XTL_XOMPLEX was set and had no issue. Do you have the logs of the error?

I had the notes ready for a potential fix, but I fell sick and lost them

Sorry to read that, I hope you're feeling better!

[amyspark]

Actually the call to find_dependency(xtl) is done in the xsimdConfig.cmake file so I'm confused why Krita does not build with xsimd. I tried a local build of xtensor with a dependency on xsimd where ENABLE_XTL_XOMPLEX was set and had no issue. Do you have the logs of the error?

https://forum.kde.org/viewtopic.php?f=288&t=176722&p=459505#p459505 and compile line looks like https://invent.kde.org/-/snippets/2224. Both point to xtl being passed over as-is without the library being resolved to its proper path.