Add batch_constant comparison and shift#1208
Merged
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom Nov 18, 2025
Merged
Add batch_constant comparison and shift#1208serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom
Conversation
| constexpr bool operator()(T x, T y) const { return x != y; } | ||
| }; | ||
| struct boolean_gt | ||
| { |
Contributor
There was a problem hiding this comment.
Better use https://en.cppreference.com/w/cpp/utility/functional/greater.html et cie?
Contributor
Author
There was a problem hiding this comment.
I wanted to but they are only constexpr since C++14
AntoinePrv
force-pushed
the
constant-comp
branch
from
a52925e to
58e1b0c
Compare
AntoinePrv
force-pushed
the
constant-comp
branch
from
73c0712 to
fb19335
Compare
AntoinePrv
changed the title
Contributor
Author
|
@serge-sans-paille this is ready for me if it is for you |
Contributor
|
This is complementary to #1162 that adds other binary ops. Might cause some merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
size_tnot being C