Skip to content

Fix C++ version detection for MSVC#1342

Merged
AntoinePrv merged 2 commits intoxtensor-stack:masterfrom
AntoinePrv:cpp-version
May 6, 2026
Merged

Fix C++ version detection for MSVC#1342
AntoinePrv merged 2 commits intoxtensor-stack:masterfrom
AntoinePrv:cpp-version

Conversation

@AntoinePrv
Copy link
Copy Markdown
Contributor

No description provided.

@AntoinePrv
Copy link
Copy Markdown
Contributor Author

@JohanMabille

@serge-sans-paille
Copy link
Copy Markdown
Contributor

LGTM. The fact that we don't detect that in CI is a problem (and a potential regression pithole). Does that mean this PR should also add msvc in the compilers tested in .github/workflows/cxx-versions.yml ?

@AntoinePrv
Copy link
Copy Markdown
Contributor Author

@serge-sans-paille I added MSVC for this build.

There is a bit of a self-referential problem here, tests were using __cplusplus to exclude checks for features with higher C++ requirement, so even with a MSVC build, they would just have been skiped as well

On top I find the CI starting to last long. I've started to think we should improve our strategy. For instance, mixing AVX2 check with C++17 etc -- same way we don't build the whole (compiler version, micro arch) matrix.
Perhaps even some smaller subset in PRs and more in main? I'll come back on this topic in another issue though.

@AntoinePrv AntoinePrv merged commit cc9ca38 into xtensor-stack:master May 6, 2026
87 checks passed
@AntoinePrv AntoinePrv deleted the cpp-version branch May 6, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants