-
Notifications
You must be signed in to change notification settings - Fork 281
Fix SSE build failure with MSVC #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@serge-sans-paille @JohanMabille |
|
I'm puzzled: I activated SSE2 testing here: #563 but it doesn't show any error |
|
Reproduced this error with below trivial code. Tested on windows-10, visual studio community 2019, Logs: |
MSVC does not define __SSEn__ macros. Currently, we have to specify /arch:AVXn for an SSE only binary.
| // NB: MSVC does not define __SSEn__ | ||
| #define XSIMD_WITH_SSE4_2 1 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit rude to always enable SSE4_2 for MSVC.
Per my understanding, 64bit MSVC supports at least SSE2, (/arch:SSE2 is actually an invalid option), and looks there's no way to detect SSE3/4 at compiler time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously this change causes windows-clang ci job failures.
Comments welcomed.
Not familiar with appveyor environment. Just blind guess. From the SSE job log, looks it's still running AVX2 tests? |
|
Close this PR. Will be fixed by #563. |
MSVC does not define
__SSEn__macros. Currently, we have to specify/arch:AVXnfor an SSE only binary.Fix #561