Skip to content

Fix SSE build failure with MSVC #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix SSE build failure with MSVC #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/xsimd/config/xsimd_config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@
// Workaround for MSVC compiler
#ifdef _MSC_VER

// NB: MSVC does not define __SSEn__
#define XSIMD_WITH_SSE4_2 1

Comment on lines +213 to +215
Copy link
Contributor Author

@cyb70289 cyb70289 Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit rude to always enable SSE4_2 for MSVC.
Per my understanding, 64bit MSVC supports at least SSE2, (/arch:SSE2 is actually an invalid option), and looks there's no way to detect SSE3/4 at compiler time.

Copy link
Contributor Author

@cyb70289 cyb70289 Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this change causes windows-clang ci job failures.
Comments welcomed.

#if XSIMD_WITH_AVX512
#define XSIMD_WITH_AVX2 1
#endif
Expand Down