Disable batch of bools, and suggest using batch_bool instead #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JohanMabille this probably requires a companion patch in xtensor. |
It was only supported on Intel architectures and wasm, for no clear reason. Provide a unified experience by enforcing batch_bool instead. If someone really wants a batch of bool, then use another type to store it, e.g. uint8_t. Fix #945
serge-sans-paille
force-pushed
the
feature/prohibit-batch-of-bool
branch
from
30cdcf6 to
ead311f
Compare
anutosh491
approved these changes
Nov 13, 2023
Contributor
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
Looks good to me. I think we can disable batch of bools
Contributor
Author
|
I'm leaving it to @JohanMabille to choose whether we should merge this or not :-) |
Member
|
I'm definitely for this, but this is a backward incompatible change. Do we have other fixes we want to get in and tag a minor release before this one? |
Contributor
Author
|
@JohanMabille I'd like to investigate the accuracy issue with some trigo functions, but that can wait. Feel free to merge this one and do a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only supported on Intel architectures and wasm, for no clear reason. Provide a unified experience by enforcing batch_bool instead. If someone really wants a batch of bool, then use another type to store it, e.g. uint8_t.
Fix #945