Fixed a few warnings that pop up on VC14#27
Merged
egpbos merged 1 commit intoxtensor-stack:masterfrom Jan 16, 2018
Merged
Conversation
masariello
force-pushed
the
0.2.2-no-warnings-on-VC14
branch
3 times, most recently
from
bfe934d to
dbefaf9
Compare
masariello
changed the title
… of significant numerical diffs on VC14 (both x64 and win32). Windows really needs a few Travis jobs
masariello
force-pushed
the
0.2.2-no-warnings-on-VC14
branch
from
dbefaf9 to
13e78ed
Compare
Member
|
Excellent, thanks! I'm sure the Mac builds will complete as well, so I'll merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed a few warnings that pop up on VC14. NB the code gives lots of significant numerical diffs on VC14 (both x64 and win32). Windows really needs a few Travis jobs.