Adjust dependency finding so lib works better as submodule#51
Merged
egpbos merged 1 commit intoxtensor-stack:masterfrom Jan 10, 2021
Merged
Conversation
- Check for xtensor and xtl targets, similar to how xtensor-python does it. - Adjust path to FindFFTW.cmake so that it uses CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR
Member
|
I'm very sorry for responding so slowly to this. Thanks for this great addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use xtensor-fftw as a submodule, I encountered two errors. One, cmake did not recognize that I had defined the xtensor and xtl build targets already, because I have submoduled those repositories. Other projects in the xtensor-stack appear to support this, so I followed the same pattern. Secondly, when searching for libfftw, the code had a path to FindFFTW.cmake that does not necessarily work when this library is used in a submodule. I adjusted the path so that it works in both cases.
it.
instead of CMAKE_SOURCE_DIR