Added target_include_directories when building shared libs to target …#50
Merged
davidbrochart merged 1 commit intoxtensor-stack:masterfrom Sep 23, 2021
Merged
Conversation
…xtensor-zarr-gdal
davidbrochart
approved these changes
Sep 23, 2021
Member
|
Thanks @dengeland ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build xtensor-zarr on Ubuntu 20.04 I run into problem because some of the gdal headers where not found. I installed gdal via sudo apt, so everything was in place and cmake find_package worked well.
Investigating a little bit more, I found, that there might be a missing target_include_directories, see the diff.