Skip to content

Fixed FindTBB.cmake#2324

Merged
JohanMabille merged 1 commit intoxtensor-stack:masterfrom
JohanMabille:tbb
Mar 15, 2021
Merged

Fixed FindTBB.cmake#2324
JohanMabille merged 1 commit intoxtensor-stack:masterfrom
JohanMabille:tbb

Conversation

@JohanMabille
Copy link
Copy Markdown
Member

@JohanMabille JohanMabille commented Mar 15, 2021

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

@JohanMabille JohanMabille merged commit 7999459 into xtensor-stack:master Mar 15, 2021
@JohanMabille JohanMabille deleted the tbb branch March 15, 2021 21:57
@zhujun98
Copy link
Copy Markdown
Contributor

zhujun98 commented Mar 16, 2021 •
edited
Loading

@JohanMabille There is some breaking change in the TBB version 2021.1, which is used by the CI now. But to make xtensor backward compatible for some system in operation, would it be better to let FindTBB.cmake first find ${TBB_INCLUDE_DIRS}/tbb/version.h and then fall back to ${TBB_INCLUDE_DIRS}/tbb/tbb_stddef.h if it fails?

@JohanMabille
Copy link
Copy Markdown
Member Author

JohanMabille commented Mar 16, 2021

Yes I agree that it would be a better fix than the one I pushed yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohanMabille @zhujun98