Rename and fix storage iterator#2534
Merged
JohanMabille merged 6 commits intoxtensor-stack:masterfrom May 12, 2022
Merged
Conversation
gouarin
force-pushed
the
rename-and-fix-storage-iterator
branch
from
b6576d8 to
f16249c
Compare
Member
|
I extremely briefly scrolled over, a small question/suggestion : should "linear" be "contiguous" ? |
Member
Author
|
We chose "linear" because this term is already used in the |
gouarin
force-pushed
the
rename-and-fix-storage-iterator
branch
from
f58f6ae to
dec6770
Compare
Member
Not really, linear means the expression can be iterated as if it was 1D only, while contiguous implies underlying data. For instanc, an |
gouarin
changed the title
Member
|
OK, that makes sense then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.