Fixed lambda return type used in xfunxtion#2913
Open
JohanMabille wants to merge 1 commit intoxtensor-stack:masterfrom
Open
Fixed lambda return type used in xfunxtion#2913JohanMabille wants to merge 1 commit intoxtensor-stack:masterfrom
JohanMabille wants to merge 1 commit intoxtensor-stack:masterfrom
Conversation
Contributor
|
Can you add a test with the original issue ? |
Member
Author
|
It's a bit hard to test, because the original issue was a dangling reference. This is not guaranteed to crash depending on how you invoke it, so a test would not really be meaningful here (we already have tests where we bind the result of such calls to reference and they pass). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2911