Configure VolumeMounts with subPath in ContainerBuilder #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobrz
approved these changes
Dec 16, 2022
Contributor
fabiobrz
left a comment
fabiobrz
left a comment
There was a problem hiding this comment.
LGTM - @mnovak1 this seems conservative to me, since the only relevant change keeps the compatibility with the existing implementation. WDYT?
jbliznak
approved these changes
Dec 16, 2022
simkam
requested changes
Dec 19, 2022
tommaso-borgato
force-pushed
the
containerbuilder-subpath
branch
from
3a4da14 to
38047a2
Compare
simkam
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduces the option to configure volumeMounts with subPath through cz.xtf.builder.builders.pod.ContainerBuilder
Please make sure your PR meets the following requirements: