Initial UTs. #1
Initial UTs. #1
Conversation
| param ( | ||
| [string]$ApiVersion = "2022-09-01" | ||
| ) | ||
|
|
||
| # This is a known endpoint. | ||
| $MetadataEndpoint = "https://management.azure.com/metadata/endpoints?api-version=$ApiVersion" | ||
|
|
||
| try { | ||
| $Response = Invoke-RestMethod -Uri $MetadataEndpoint -Method Get -StatusCodeVariable StatusCode | ||
|
|
||
| if ($StatusCode -ne 200) { | ||
| $Msg = "ARM metadata endpoint '$MetadataEndpoint' returned status code $($StatusCode)." | ||
| throw $Msg | ||
| } | ||
| } | ||
| catch { | ||
| $Msg = "Failed to request ARM metadata $MetadataEndpoint." | ||
| Write-Error "$Msg Please ensure you have network connection. Error: $_" | ||
| } | ||
|
|
There was a problem hiding this comment.
Because it is replaced by the code below.
src/ConnectedKubernetes/ConnectedKubernetes.Autorest/custom/helpers/ConfigDPHelper.ps1
Show resolved
Hide resolved
|
|
||
| # Get the default config dataplane endpoint. | ||
| if (-not $ConfigDpEndpoint) { | ||
| if ($null -eq $ConfigDpEndpoint) { |
There was a problem hiding this comment.
Out of curiosity, is $null -eq a standard way?
There was a problem hiding this comment.
Invoke-ScriptAnalyzer prefers this way around. Not totally sure why but I do know in "C" that this was preferred incase you mistyped if (field == NULL) as if (field = NULL) - both compile but if (NULL = field) will not!
| $chartLocationUrlSegment = "azure-arc-k8sagents/healthCheck?api-version=$apiVersion" | ||
| $chartLocationUrl = "$configDPEndpoint/$chartLocationUrlSegment" | ||
| $uriParameters = @{} | ||
| $uriParameters = [ordered]@{} |
There was a problem hiding this comment.
I wanted to be able to test and without "ordered" you cannot be sure what order the resulting URI string will have the parameters in.
| $uriParameters = [ordered]@{} | ||
| Invoke-RestMethodWithUriParameters ` | ||
| -Method "POST" ` | ||
| -Uri "https://invalid.invalid/some/page/nowhere" ` |
There was a problem hiding this comment.
Anyway to extract into a shared constant?
| $configDpEndpoint | Should -Be "https://eastus2.dp.kubernetesconfiguration.azure.com" | ||
| } | ||
|
|
||
| # !!PDS: How do we validate this? Need to check endpoint on a sovereign cloud. |
There was a problem hiding this comment.
What does sovereign login endpoint look like?
There was a problem hiding this comment.
https://login.chinacloudapi.cn/ for example but it appears that the az CLI assumes 3 URI components and only wants to extract the last one.
There was a problem hiding this comment.
sounds like it's for mooncake and fairfax?
There was a problem hiding this comment.
Yes but do you have access to them? Not sure I do and the endpoints appear to return errors when I try. Perhaps they just don't have the update DP deployed yet though.
| { | ||
| $loadEnvPath = Join-Path $PSScriptRoot 'loadEnv.ps1' | ||
| if (-Not (Test-Path -Path $loadEnvPath)) { | ||
| $loadEnvPath = Join-Path $PSScriptRoot '..\loadEnv.ps1' |
There was a problem hiding this comment.
A general question on UT, how to test those functions in helpers separately?
There was a problem hiding this comment.
I have not figured that out yet but it would certainly be good if we could. I also don't like the current import process.
Adding some unit tests.
REVIEWER
Mocked methods?