Editing a page that has an embeded document doesn't work properly #79#80
Merged
Farcasut merged 2 commits intoxwikisas:masterfrom Jul 31, 2024
Merged
Editing a page that has an embeded document doesn't work properly #79#80Farcasut merged 2 commits intoxwikisas:masterfrom
Farcasut merged 2 commits intoxwikisas:masterfrom
Conversation
…kisas#79 * The issue was a more generic one. This behavior replicates with both Groovy and Velocity when the HTML has clean=false and we want to add text below an iframe. I've made an issue on the platform for this, and as a workaround, I removed the clean=false property.
…kisas#79 * In the meantime, the issue was resolved (https://jira.xwiki.org/browse/XWIKI-22366?jql=project%20%3D%20XWIKI%20AND%20component%20%3D%20Rendering). The initial structure was generating invalid HTML, and because of this, WYSIWYG was moving nodes around. To solve this, I need to add the block wrapper myself.
trrenty
approved these changes
Jul 30, 2024
oanalavinia
pushed a commit
that referenced
this pull request
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.xwiki.org/browse/XWIKI-22366