To do list hw#4 5#45
Open
Kateryna-Borysenko wants to merge 28 commits intoxzfantom:mainfrom
Open
Conversation
Owner
|
Круто. Сижу залипаю в код как такое делать)) |
Author
|
спасибо 😊
…On Tue, 9 Aug 2022 at 22:53, Tay811 ***@***.***> wrote:
Круто. Сижу залипаю в код как такое делать))
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATQ5TXQT7FJPXQI2LW5OXYLVYKZJXANCNFSM56BTND6Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
poulkud
reviewed
Aug 10, 2022
| <Route exact path='/'> | ||
| <AboutUsPage /> | ||
| </Route> | ||
|
|
poulkud
reviewed
Aug 10, 2022
| <button | ||
| className={sort === 'completed' ? s.active : s.button} | ||
| type='button' | ||
| onClick={() => setSort('completed')} |
Collaborator
There was a problem hiding this comment.
можно вынести в отдельную функцию в которую можно передавать нужные аргументы
poulkud
reviewed
Aug 10, 2022
| }; | ||
| }; | ||
|
|
||
| export default connect(mapStateToProps, mapDispatchToProps)(DisplayTodos); |
Collaborator
There was a problem hiding this comment.
в целом ок, но мы говорили не используем connect
Collaborator
There was a problem hiding this comment.
но это не критично, все ок
poulkud
reviewed
Aug 10, 2022
| value={todo} | ||
| ref={inputRef} | ||
| /> | ||
| <button onClick={() => add()} className={s.todoButton}> |
poulkud
reviewed
Aug 10, 2022
| return ( | ||
| <div className={s.wrap}> | ||
| <span className={s.todos}> | ||
| Active:{' '} |
Collaborator
There was a problem hiding this comment.
тут можно s.numberTodos задать маржин нужный, такие пробелы лишние
poulkud
reviewed
Aug 10, 2022
| margin-top: 0; | ||
| margin-bottom: 0; | ||
| list-style: none; | ||
| } */ |
poulkud
approved these changes
Aug 10, 2022
Collaborator
poulkud
left a comment
poulkud
left a comment
There was a problem hiding this comment.
поправить комменты и апрув
Author
|
Спасибо
…On Wed, 10 Aug 2022 at 19:20, Pavel kudryavtsev ***@***.***> wrote:
***@***.**** approved this pull request.
поправить комменты и апрув
—
Reply to this email directly, view it on GitHub
<#45 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATQ5TXWBM2L7UNRR54ZI53LVYPJEFANCNFSM56BTND6Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Привет