feat(webui): Enforce consistent border radius by constraining overflow in Monaco editor; Improve vertical text alignment. #1393
Conversation
WalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
components/webui/client/src/components/SqlEditor/index.module.css(1 hunks)components/webui/client/src/components/SqlInput/index.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}
⚙️ CodeRabbit configuration file
- Prefer
false == <expression>rather than!<expression>.
Files:
components/webui/client/src/components/SqlInput/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: package-image
- GitHub Check: lint-check (ubuntu-24.04)
- GitHub Check: lint-check (macos-15)
- GitHub Check: rust-checks (ubuntu-24.04)
- GitHub Check: rust-checks (ubuntu-22.04)
- GitHub Check: rust-checks (macos-15)
🔇 Additional comments (2)
components/webui/client/src/components/SqlEditor/index.module.css (1)
9-13: LGTM! Border radius and overflow handling are appropriate.The CSS rule correctly targets Monaco editor internal elements to apply consistent border radius and clip overflow. The use of
!importantis justified here to override third-party library styles.components/webui/client/src/components/SqlInput/index.tsx (1)
49-52: LGTM! Verify the vertical alignment improvement.The padding adjustment should improve vertical text centering in the single-line editor. Since the PR description indicates validation is pending, please ensure the visual appearance is as intended across different browser configurations.
components/webui/client/src/components/SqlEditor/index.module.css
Outdated
Show resolved
Hide resolved
components/webui/client/src/components/SqlEditor/index.module.css
Outdated
Show resolved
Hide resolved
components/webui/client/src/components/SqlEditor/index.module.css
Outdated
Show resolved
Hide resolved
Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com>
junhaoliao
left a comment
There was a problem hiding this comment.
deferring to @hoophalab 's review
|
We probably need to change the title. How about this title: Does |
Description
Previously border radius only applied to outer border, but monaco had additional elements that had no radius, which looked a bit weird on rendering. Also, the text in the single-line editor alignment was off, this PR aligns closer to the centre.
Checklist
breaking change.
Validation performed
Both issues fixed
Summary by CodeRabbit