refactor(helm): Standardize template formatting across deployments:#1822
refactor(helm): Standardize template formatting across deployments:#1822junhaoliao merged 11 commits intoy-scope:mainfrom
Conversation
WalkthroughHelm chart templates updated: numeric ConfigMap fields coerced to integers and host interpolations quoted; several deployments/statefulsets had volumeMount ordering adjusted, some containers had CLI args (including Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # tools/deployment/package-helm/templates/configmap.yaml
tools/deployment/package-helm/templates/query-scheduler-deployment.yaml
Outdated
Show resolved
Hide resolved
| readinessProbe: | ||
| {{- include "clp.readinessProbeTimings" . | nindent 12 }} | ||
| tcpSocket: &query-scheduler-health-check | ||
| port: 7000 | ||
| port: "query-scheduler" | ||
| livenessProbe: | ||
| {{- include "clp.livenessProbeTimings" . | nindent 12 }} | ||
| tcpSocket: *query-scheduler-health-check |
There was a problem hiding this comment.
Can we move these below the command like they are in other deployments?
kirkrodrigues
left a comment
There was a problem hiding this comment.
I think the current PR title is a bit vague. Maybe we can come up with a multi-line commit message?
…-scope#1822) - Add `| int` casts to prevent scientific notation in `configmap.yaml`. - Use named ports for Web UI and Query Scheduler health checks. - Quote dynamically-generated host values for consistent string formatting. - Reorder `volumeMounts` to list template usages before static items.
Description
Note
This PR is part of the ongoing work for #1309. More PRs will be submitted until the Helm chart is complete and fully functional.
This PR improves template formatting and consistency in the Helm chart:
| intcasts to all integer values inconfigmap.yamlto ensure proper YAML type handling; otherwise, integers values might be treated as floats, and scientific notation might be used.configmap.yamlfor consistent string formattingvolumeMountsinreducer-deployment.yamlandquery-scheduler-deployment.yamlto follow the established ordering convention (template helper usages before static items)Checklist
breaking change.
Validation performed
integersare| intprocessed.test.shscript and observed the cluster was up:Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.