fix(clp-s): Identify empty files in try_deduce_reader_type; Accept empty files as input in clp-s and log-converter (fixes #1993, #2063).#2138
Merged
gibber9809 merged 2 commits intoy-scope:mainfrom Mar 30, 2026
Conversation
Contributor
WalkthroughThis pull request introduces handling for empty files in the CLP compression pipeline. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
try_deduce_reader_type; accept empty files as input in clp-s and log-converter (fixes #1993, #2063).try_deduce_reader_type; accept empty files as input in clp-s and log-converter (fixes #1993, #2063).
try_deduce_reader_type; accept empty files as input in clp-s and log-converter (fixes #1993, #2063).try_deduce_reader_type; Accept empty files as input in clp-s and log-converter (fixes #1993, #2063).
LinZhihao-723
approved these changes
Mar 30, 2026
Member
LinZhihao-723
left a comment
There was a problem hiding this comment.
lgtm. Directly modified the PR title to change accept to Accept.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an oversight in clp-s' input utilities where the utilities to indentify the type of an input file don't account for empty files. We add support for detecting empty files as a file type, and use it to support ingesting empty files in
clp-sandlog-converter.While fixing this issue I noticed that we currently don't support reading archives composed exclusively of empty files -- this issue is tracked in #2137.
Checklist
breaking change.
Validation performed
log-converterand observed that it produceskv-irfile with zero records as expected1.a Passed the
kv-irfile with zero records toclp-sand observed that it creates an archive with zero records and metadata recording the empty file as expectedclp-sand observed that it produces an archive with zero records and metadata recording the empty file as expectedSummary by CodeRabbit