Skip to content

fix(taskfiles): Enable globstar in main taskfile so that **/* works properly in shell commands; Enable pipefail in main taskfile. #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

fix(taskfiles): Enable globstar in main taskfile so that **/* works properly in shell commands; Enable pipefail in main taskfile. #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c1f544
Fix taskfile with linting rerun.
LinZhihao-723 May 13, 2025
828fd6a
Also set pipfall.
LinZhihao-723 May 13, 2025
169a412
Merge branch 'main' into taskfile-fix
LinZhihao-723 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions components/core/tests/test-ir_encoding_methods.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,8 +708,8 @@ TEMPLATE_TEST_CASE(
// Check if encoding type is properly read
BufferReader ir_buffer{size_checked_pointer_cast<char const>(ir_buf.data()), ir_buf.size()};
bool is_four_bytes_encoding;
REQUIRE(get_encoding_type(ir_buffer, is_four_bytes_encoding) == IRErrorCode::IRErrorCode_Success
);
REQUIRE(get_encoding_type(ir_buffer, is_four_bytes_encoding)
== IRErrorCode::IRErrorCode_Success);
REQUIRE(match_encoding_type<TestType>(is_four_bytes_encoding));
REQUIRE(MagicNumberLength == ir_buffer.get_pos());

Expand Down Expand Up @@ -831,7 +831,8 @@ TEMPLATE_TEST_CASE(
ir_buf.size()
};
REQUIRE(IRErrorCode::IRErrorCode_Success == deserialize_tag(incomplete_preamble_buffer, tag));
REQUIRE(IRErrorCode::IRErrorCode_Incomplete_IR
REQUIRE(
IRErrorCode::IRErrorCode_Incomplete_IR
== deserialize_log_event<TestType>(incomplete_preamble_buffer, tag, message, timestamp)
);
}
Expand Down
10 changes: 4 additions & 6 deletions components/core/tests/test-kql.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,8 @@ TEST_CASE("Test parsing KQL", "[KQL]") {
SECTION("Namespaced column") {
auto namespace_name = GENERATE("@", "$", "!", "#");
auto namespaced_query_fmt_string = GENERATE("{}column : *", "\"{}column\": *");
auto namespaced_query = fmt::vformat(
namespaced_query_fmt_string,
fmt::make_format_args(namespace_name)
);
auto namespaced_query
= fmt::vformat(namespaced_query_fmt_string, fmt::make_format_args(namespace_name));
stringstream query{namespaced_query};
auto filter = std::dynamic_pointer_cast<FilterExpr>(parse_kql_expression(query));
REQUIRE(nullptr != filter);
Expand All @@ -304,8 +302,8 @@ TEST_CASE("Test parsing KQL", "[KQL]") {
auto escaped_namespace_query_fmt_string = GENERATE("\\{}column : *", "\"\\{}column\": *");
auto column = fmt::vformat("{}column", fmt::make_format_args(namespace_name));
auto escaped_namespace_query = fmt::vformat(
escaped_namespace_query_fmt_string,
fmt::make_format_args(namespace_name)
escaped_namespace_query_fmt_string,
fmt::make_format_args(namespace_name)
);
stringstream query{escaped_namespace_query};
auto filter = std::dynamic_pointer_cast<FilterExpr>(parse_kql_expression(query));
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-string_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ SCENARIO("Test case sensitive wild card match in all possible ways", "[wildcard]
REQUIRE(wildcard_match_unsafe_case_sensitive(tameString, wildString) == false);
}

GIVEN("MISSING matching literals in the beginning with both \"*\" and \"?\" in the middle"
GIVEN(
"MISSING matching literals in the beginning with both \"*\" and \"?\" in the middle"
) {
tameString = "abcd", wildString = "b*?d";
REQUIRE(wildcard_match_unsafe_case_sensitive(tameString, wildString) == false);
Expand Down
3 changes: 3 additions & 0 deletions taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
version: "3"

set: ["u", "pipefail"]
Copy link
Contributor

@coderabbitai coderabbitai bot May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Optional: Consider enabling exit-on-error (e)
The current set: ["u", "pipefail"] will treat unset variables as errors and cause pipelines to fail if any component fails, but individual failing commands in a pipeline may not abort the task immediately. It’s a common best practice to include e so that the shell exits on any error (equivalent to set -euo pipefail).

You can apply this diff if you want stricter fail-fast behaviour:

-set: ["u", "pipefail"]
+set: ["e", "u", "pipefail"]

shopt: ["globstar"]

includes:
deps: "taskfiles/deps/main.yaml"
docs: "taskfiles/docs.yaml"
Expand Down
Loading