Skip to content

feat: Add CMakeLists.txt files and helper function for building interface libraries. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 3, 2025
Merged

feat: Add CMakeLists.txt files and helper function for building interface libraries. #17

merged 21 commits into from
Feb 3, 2025

Conversation

@Bill-hbrhbr
Copy link
Collaborator

@Bill-hbrhbr Bill-hbrhbr commented Jan 27, 2025 •
edited
Loading

Description

  • Add a complete boilerplate CMake project with a dummy header-only interface library and a dummy executable that calls the library.
  • Implement custom CMake command cpp_library to simplify the CMakeLists.txt of each individual ystdlib-cpp lib
  • Added more exclusion paths to CMake gersmi linters

Does not support installing ystdlib into system paths yet.

Validation performed

  • The project build succeeds and the executable can run successfully.

@Bill-hbrhbr Bill-hbrhbr marked this pull request as ready for review January 27, 2025 18:49
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion January 27, 2025 18:51
@davidlion davidlion marked this pull request as draft January 27, 2025 18:52
@Bill-hbrhbr Bill-hbrhbr marked this pull request as ready for review January 27, 2025 23:06
@Bill-hbrhbr Bill-hbrhbr changed the title feat: Add CMake features for managing interface libraries of ystdlib-cpp. feat: Add CMake features for building interface libraries of ystdlib-cpp. Jan 27, 2025
davidlion
davidlion requested changes Jan 31, 2025
View reviewed changes
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion February 1, 2025 04:48
davidlion
davidlion requested changes Feb 3, 2025
View reviewed changes
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion February 3, 2025 08:45
@davidlion davidlion changed the title feat: Add CMake features for building interface libraries of ystdlib-cpp. feat: Add CMakeLists.txt files and helper function for building interface libraries. Feb 3, 2025
davidlion
davidlion requested changes Feb 3, 2025
View reviewed changes
Bill-hbrhbr and others added 3 commits February 3, 2025 04:23
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion February 3, 2025 09:31
davidlion
davidlion previously approved these changes Feb 3, 2025
View reviewed changes
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion February 3, 2025 09:38
@Bill-hbrhbr Bill-hbrhbr merged commit b92875f into y-scope:main Feb 3, 2025
6 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the header-only branch February 3, 2025 18:47
@Bill-hbrhbr Bill-hbrhbr mentioned this pull request Mar 14, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidlion davidlion Awaiting requested review from davidlion

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bill-hbrhbr @davidlion